Add Aqua tests; organize Project toml a bit better#14
Merged
mateuszbaran merged 6 commits intomainfrom Apr 21, 2026
Merged
Conversation
zazabap
reviewed
Apr 21, 2026
Contributor
There was a problem hiding this comment.
Direction looks good. Just one small nits before registering:
docs/src/index.mdline 8 has a stray=== Markdown summary table ===— looks like theprintlnheader frombenchmarks/main.jlgot pasted in along with the table.
Workspace layout, Aqua tests, and Sphere additions all look fine on my end.
Member
Author
|
Thanks for checking, I've deleted that line. I will submit the package for registration soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think the package is now good enough to register it and make a first release, so this PR is supposed to prepare it. @zazabap Do you want to change something here before registration?